Bug 129858 - JSGlobalContextRelease incorrectly handles saving/restoring IdentifierTable
Summary: JSGlobalContextRelease incorrectly handles saving/restoring IdentifierTable
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-06 18:27 PST by Mark Hahnenberg
Modified: 2014-03-06 19:24 PST (History)
1 user (show)

See Also:

Attachments
Patch (1.98 KB, patch)
2014-03-06 18:29 PST, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2014-03-06 18:27:09 PST 
It was correct (but really ugly) prior to the combining of APIEntryShim and JSLock, but now it ends up overwriting the IdentifierTable.
Comment 1 Mark Hahnenberg 2014-03-06 18:27:52 PST 
<rdar://problem/15511394>
Comment 2 Mark Hahnenberg 2014-03-06 18:29:57 PST 
Created attachment 226073 [details]
Patch
Comment 3 Mark Lam 2014-03-06 18:40:05 PST 
Comment on attachment 226073 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2014-03-06 19:24:10 PST 
Comment on attachment 226073 [details]
Patch

Clearing flags on attachment: 226073

Committed r165244: <http://trac.webkit.org/changeset/165244>
Comment 5 WebKit Commit Bot 2014-03-06 19:24:11 PST 
All reviewed patches have been landed.  Closing bug.