Bug 129836 - CodeGeneratorJS.pm doesn't need to add spaces between consecutive closing template brackets
Summary: CodeGeneratorJS.pm doesn't need to add spaces between consecutive closing tem...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: BJ Burg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-06 15:21 PST by BJ Burg
Modified: 2014-03-07 10:10 PST (History)
6 users (show)

See Also:

Attachments
the patch (2.44 KB, patch)
2014-03-06 16:50 PST, BJ Burg 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2014-03-06 15:21:30 PST 
There are a few little cases where it tries to avoid a compiler error we won't ever hit now.
Comment 1 BJ Burg 2014-03-06 16:50:51 PST 
Created attachment 226063 [details]
the patch
Comment 2 WebKit Commit Bot 2014-03-06 18:18:10 PST 
Comment on attachment 226063 [details]
the patch

Clearing flags on attachment: 226063

Committed r165242: <http://trac.webkit.org/changeset/165242>
Comment 3 WebKit Commit Bot 2014-03-06 18:18:14 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Csaba Osztrogonác 2014-03-06 22:47:40 PST 
(In reply to comment #2)
> (From update of attachment 226063 [details])
> Clearing flags on attachment: 226063
> 
> Committed r165242: <http://trac.webkit.org/changeset/165242>

It broke the bindings tests, please fix it.
Comment 5 BJ Burg 2014-03-07 10:10:37 PST 
(In reply to comment #4)
> (In reply to comment #2)
> > (From update of attachment 226063 [details] [details])
> > Clearing flags on attachment: 226063
> > 
> > Committed r165242: <http://trac.webkit.org/changeset/165242>
> 
> It broke the bindings tests, please fix it.

Ugh, I forgot those still aren't run by EWS. Will fix.