RESOLVED FIXED 129836
CodeGeneratorJS.pm doesn't need to add spaces between consecutive closing template brackets 
https://bugs.webkit.org/show_bug.cgi?id=129836
Summary CodeGeneratorJS.pm doesn't need to add spaces between consecutive closing tem...
Blaze Burg
Reported 2014-03-06 15:21:30 PST
There are a few little cases where it tries to avoid a compiler error we won't ever hit now.
Attachments
the patch (2.44 KB, patch)
2014-03-06 16:50 PST, Blaze Burg 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Blaze Burg
Comment 1 2014-03-06 16:50:51 PST
Created attachment 226063 [details] the patch
WebKit Commit Bot
Comment 2 2014-03-06 18:18:10 PST
Comment on attachment 226063 [details] the patch Clearing flags on attachment: 226063 Committed r165242: <http://trac.webkit.org/changeset/165242>
WebKit Commit Bot
Comment 3 2014-03-06 18:18:14 PST
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 4 2014-03-06 22:47:40 PST
(In reply to comment #2) > (From update of attachment 226063 [details]) > Clearing flags on attachment: 226063 > > Committed r165242: <http://trac.webkit.org/changeset/165242> It broke the bindings tests, please fix it.
Blaze Burg
Comment 5 2014-03-07 10:10:37 PST
(In reply to comment #4) > (In reply to comment #2) > > (From update of attachment 226063 [details] [details]) > > Clearing flags on attachment: 226063 > > > > Committed r165242: <http://trac.webkit.org/changeset/165242> > > It broke the bindings tests, please fix it. Ugh, I forgot those still aren't run by EWS. Will fix.
Note You need to log in before you can comment on or make changes to this bug.