Bug 129804 - [WebRTC] Updating RTCPeerConnection.idl
Summary: [WebRTC] Updating RTCPeerConnection.idl
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Thiago de Barros Lacerda
URL:
Keywords:
Depends on:
Blocks: 124288 129845
  Show dependency tree / graph
 
Reported: 2014-03-06 08:11 PST by Thiago de Barros Lacerda
Modified: 2014-05-19 09:08 PDT (History)
11 users (show)

See Also:

Attachments
Patch (13.85 KB, patch)
2014-03-06 16:32 PST, Thiago de Barros Lacerda 		eric.carlson: review+
thiago.lacerda: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (14.06 KB, patch)
2014-03-06 20:51 PST, Thiago de Barros Lacerda 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thiago de Barros Lacerda 2014-03-06 08:11:07 PST 
Some methods signatures were wrong, marking some arguments as optional when they are mandatory.
Comment 1 Thiago de Barros Lacerda 2014-03-06 16:32:26 PST 
Created attachment 226060 [details]
Patch
Comment 2 Eric Carlson 2014-03-06 19:46:26 PST 
Comment on attachment 226060 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=226060&action=review

> LayoutTests/fast/mediastream/RTCPeerConnection-statsSelector.html:40
> +                shouldNotThrow('pc.getStats(statsHandler2, statsError, pc.getLocalStreams()[0].getVideoTracks()[0])');

If we don't already have tests to check the error callback, please file a bug so we remember to add them.
Comment 3 Thiago de Barros Lacerda 2014-03-06 20:51:54 PST 
Created attachment 226080 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2014-03-06 21:37:12 PST 
Comment on attachment 226080 [details]
Patch for landing

Clearing flags on attachment: 226080

Committed r165248: <http://trac.webkit.org/changeset/165248>