Bug 129773 - [iOS] Rename the actualVisibleXXXRect to unobscuredContentRect for consistency
Summary: [iOS] Rename the actualVisibleXXXRect to unobscuredContentRect for consistency
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-05 19:47 PST by Benjamin Poulain
Modified: 2014-03-06 13:45 PST (History)
6 users (show)

See Also:


Attachments
Patch (6.89 KB, patch)
2014-03-05 19:48 PST, Benjamin Poulain
no flags Details | Formatted Diff | Diff
Patch (6.90 KB, patch)
2014-03-05 21:15 PST, Benjamin Poulain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2014-03-05 19:47:53 PST
[iOS] Rename the actualVisibleXXXRect to unoscuredContentRect for consistency
Comment 1 Benjamin Poulain 2014-03-05 19:48:10 PST
Created attachment 225943 [details]
Patch
Comment 2 Daniel Bates 2014-03-05 20:53:18 PST
Comment on attachment 225943 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=225943&action=review

> Source/WebCore/ChangeLog:3
> +        [iOS] Rename the actualVisibleXXXRect to unoscuredContentRect for consistency

I take it you mean unobscuredContentRect.

Note, you used "unoscured" (sic) throughout this patch.
Comment 3 Benjamin Poulain 2014-03-05 21:02:37 PST
(In reply to comment #2)
> (From update of attachment 225943 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=225943&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        [iOS] Rename the actualVisibleXXXRect to unoscuredContentRect for consistency
> 
> I take it you mean unobscuredContentRect.
> 
> Note, you used "unoscured" (sic) throughout this patch.

ahahah, the joy of copy-paste :)

I'll update :)
Comment 4 Benjamin Poulain 2014-03-05 21:15:40 PST
Created attachment 225949 [details]
Patch
Comment 5 Benjamin Poulain 2014-03-06 13:45:31 PST
Comment on attachment 225949 [details]
Patch

Clearing flags on attachment: 225949

Committed r165211: <http://trac.webkit.org/changeset/165211>
Comment 6 Benjamin Poulain 2014-03-06 13:45:33 PST
All reviewed patches have been landed.  Closing bug.