Bug 129754 - JSObject::fastGetOwnPropertySlot does a slow check for OverridesGetOwnPropertySlot
Summary: JSObject::fastGetOwnPropertySlot does a slow check for OverridesGetOwnPropert...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-05 13:19 PST by Mark Hahnenberg
Modified: 2014-03-05 19:15 PST (History)
1 user (show)

See Also:

Attachments
Patch (4.06 KB, patch)
2014-03-05 13:21 PST, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2014-03-05 13:19:56 PST 
It should just use the InlineTypeFlags in JSCell.
Comment 1 Mark Hahnenberg 2014-03-05 13:21:05 PST 
Created attachment 225907 [details]
Patch
Comment 2 Geoffrey Garen 2014-03-05 13:26:31 PST 
Comment on attachment 225907 [details]
Patch

r=me

Is speedup?
Comment 3 Mark Hahnenberg 2014-03-05 18:54:11 PST 
(In reply to comment #2)
> (From update of attachment 225907 [details])
> r=me
> 
> Is speedup?

Doesn't affect any of the usual benchmarks, although that's not surprising since we didn't see a regression from it after 32-bit structures.
Comment 4 WebKit Commit Bot 2014-03-05 19:14:56 PST 
Comment on attachment 225907 [details]
Patch

Clearing flags on attachment: 225907

Committed r165164: <http://trac.webkit.org/changeset/165164>
Comment 5 WebKit Commit Bot 2014-03-05 19:15:03 PST 
All reviewed patches have been landed.  Closing bug.