Bug 129723 – [iOS] Show external device name/type in placeholder

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Eric Carlson]

Show the external device type and name in the <video> placeholder image.

[Eric Carlson]

<rdar://problem/16100149>

[Eric Carlson]

Created attachment 225840 [details]
Proposed patch.

[WebKit Commit Bot]

Attachment 225840 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp:179:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
ERROR: Source/WebCore/html/HTMLMediaSession.cpp:203:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 2 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Eric Carlson]

The elf build error doesn't have anything to do with this patch:

Last 500 characters of output:
ct Source/WebCore/CMakeFiles/WebCore.dir/__/__/DerivedSources/WebCore/JSAudioContext.cpp.o
c++: internal compiler error: Killed (program cc1plus)
Please submit a full bug report,
with preprocessed source if appropriate.

[Eric Carlson]

Created attachment 225848 [details]
Out damned space!

[Jer Noble]

Comment on attachment 225848 [details]
Out damned space!

View in context: https://bugs.webkit.org/attachment.cgi?id=225848&action=review

r=me, with nit.

> Source/WebCore/html/HTMLMediaSession.cpp:217
> +String HTMLMediaSession::wirelessPlaybackTargetDisplayName(const HTMLMediaElement& element) const
> +{
> +    MediaPlayer* player = element.player();
> +    if (!player) {
> +        LOG(Media, "HTMLMediaSession::currentPlaybackTargetDisplayName - returning \"\" because player is NULL");
> +        return emptyString();
> +    }
> +    
> +    String name = player->wirelessPlaybackTargetName();
> +    LOG(Media, "HTMLMediaSession::currentPlaybackTargetDisplayName - returning \"%s\"", name.utf8().data());
> +    
> +    return name;
> +}
> +
> +MediaPlayer::WirelessPlaybackTargetType HTMLMediaSession::wirelessPlaybackTargetType(const HTMLMediaElement& element) const
> +{
> +    MediaPlayer* player = element.player();
> +    if (!player) {
> +        LOG(Media, "HTMLMediaSession::wirelessPlaybackTargetType - returning 0 because player is NULL");
> +        return MediaPlayer::TargetTypeNone;
> +    }
> +    
> +    MediaPlayer::WirelessPlaybackTargetType type = player->wirelessPlaybackTargetType();
> +    LOG(Media, "HTMLMediaSession::currentPlaybackTargetDisplayName - returning %i", static_cast<int>(type));
> +    
> +    return type;
> +}
> +    

Why is this being routed through HTMLMediaSession?  It seems like this could either go into the MediaControlsHost or HTMLMediaElement.

[Eric Carlson]

Committed r165125: https://trac.webkit.org/r165125