Bug 129722 - [WebGL] Use WKSI to see what the system policy for WebGL is
Summary: [WebGL] Use WKSI to see what the system policy for WebGL is
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-04 18:39 PST by Dean Jackson
Modified: 2014-03-05 17:16 PST (History)
3 users (show)

See Also:

Attachments
Patch (17.73 KB, patch)
2014-03-04 18:48 PST, Dean Jackson 		no flags Details | Formatted Diff | Diff
Patch (16.63 KB, patch)
2014-03-05 11:16 PST, Dean Jackson 		no flags Details | Formatted Diff | Diff
Patch (14.06 KB, patch)
2014-03-05 16:33 PST, Dean Jackson 		thorton: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2014-03-04 18:39:13 PST 
WKSI exposes the system policy for WebGL. Query that when creating a context, and let the client know about the state.
Comment 1 Dean Jackson 2014-03-04 18:40:25 PST 
<rdar://problem/15790542>
Comment 2 Dean Jackson 2014-03-04 18:48:35 PST 
Created attachment 225839 [details]
Patch
Comment 3 Dean Jackson 2014-03-04 18:49:07 PST 
This patch won't compile until the WKSI bits land, but it is ready for review.
Comment 4 WebKit Commit Bot 2014-03-04 18:50:24 PST 
Attachment 225839 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:989:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 1 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Brent Fulgham 2014-03-05 09:10:13 PST 
This looks fine to me (I was all set to reject for missing iOS, but of course that doesn't apply here!).

I think you need an official WK2 reviewer, which I am not.  But the OGL and WKSI side of things look great to me.
Comment 6 Dean Jackson 2014-03-05 11:16:11 PST 
Created attachment 225893 [details]
Patch
Comment 7 Dean Jackson 2014-03-05 11:18:20 PST 
This also won't compile until WKSI is in, and will complain about style... again.
Comment 8 WebKit Commit Bot 2014-03-05 11:18:33 PST 
Attachment 225893 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:989:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 1 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 9 Dean Jackson 2014-03-05 16:33:58 PST 
Created attachment 225927 [details]
Patch
Comment 10 Dean Jackson 2014-03-05 16:35:03 PST 
Might build now :)
Comment 11 WebKit Commit Bot 2014-03-05 16:35:47 PST 
Attachment 225927 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/API/C/WKPage.cpp:989:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 12 Dean Jackson 2014-03-05 17:16:53 PST 
Committed r165148: <http://trac.webkit.org/changeset/165148>