Bug 129690 - [iOS WebKit2]: Next/Prev button in the accessory bar do not work
Summary: [iOS WebKit2]: Next/Prev button in the accessory bar do not work
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Enrica Casucci
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-03-04 11:30 PST by Enrica Casucci
Modified: 2014-03-04 14:47 PST (History)
0 users

See Also:


Attachments
Patch (6.85 KB, patch)
2014-03-04 11:34 PST, Enrica Casucci
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Enrica Casucci 2014-03-04 11:30:10 PST
This bug track the work required to implement this functionality on iOS.
<rdar://problem/16073569>
Comment 1 Enrica Casucci 2014-03-04 11:34:08 PST
Created attachment 225796 [details]
Patch
Comment 2 Simon Fraser (smfr) 2014-03-04 11:42:50 PST
Comment on attachment 225796 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=225796&action=review

> Source/WebKit2/UIProcess/WebPageProxy.h:483
> +    void nextAssistedNode(bool isForward);

It's not clear if this is a getter or a command. I think it should be focusNextAssistedNode, or moveToNextAssistedNode. It would also be nice if the param were an enum.

> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:1594
> +static inline bool hasFocusableNode(Node* startNode, Page* page, bool isForward)
> +{
> +    return nextFocusableNode(startNode, page, isForward) != nil;
> +}
> +
> +void WebPage::nextAssistedNode(bool isForward)
> +{
> +    Node* nextNode = nextFocusableNode(m_assistedNode.get(), m_page.get(), isForward);
> +    if (nextNode)
> +        toElement(nextNode)->focus();
> +}

I think all these Node* should really be Element* (but should be fixed in a subsequent patch)
Comment 3 Enrica Casucci 2014-03-04 14:47:24 PST
Committed revision 165081.