Bug 129662 - Don't synchronize attributes in reflect setters when we don't need to
Summary: Don't synchronize attributes in reflect setters when we don't need to
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-03-04 00:52 PST by Ryosuke Niwa
Modified: 2014-03-04 11:07 PST (History)
14 users (show)

See Also:

Attachments
Fixes the bug (3.91 KB, patch)
2014-03-04 01:07 PST, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2014-03-04 00:52:32 PST 
We're currently calling setAttribute on every setters generated by "Reflect" keyword in IDL.
Comment 1 Radar WebKit Bug Importer 2014-03-04 00:53:05 PST 
<rdar://problem/16220728>
Comment 2 Ryosuke Niwa 2014-03-04 01:07:04 PST 
Created attachment 225748 [details]
Fixes the bug
Comment 3 Ryosuke Niwa 2014-03-04 02:43:04 PST 
Comment on attachment 225748 [details]
Fixes the bug

Clearing flags on attachment: 225748

Committed r165046: <http://trac.webkit.org/changeset/165046>
Comment 4 Ryosuke Niwa 2014-03-04 02:43:08 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Csaba Osztrogonác 2014-03-04 07:36:49 PST 
(In reply to comment #3)
> (From update of attachment 225748 [details])
> Clearing flags on attachment: 225748
> 
> Committed r165046: <http://trac.webkit.org/changeset/165046>

It broke the bindings tests. Could you fix them?
Comment 6 Antti Koivisto 2014-03-04 11:07:22 PST 
Updated bindings test results in https://trac.webkit.org/r165062