Bug 129603 - Move EvasGLContext and EvasGLSurface files into the efl common directory.
Summary: Move EvasGLContext and EvasGLSurface files into the efl common directory.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Linux
: P2 Normal
Assignee: Hyowon Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-03 04:05 PST by Hyowon Kim
Modified: 2014-03-04 00:20 PST (History)
8 users (show)

See Also:

Attachments
Patch (22.11 KB, patch)
2014-03-03 04:20 PST, Hyowon Kim 		no flags Details | Formatted Diff | Diff
Patch (22.10 KB, patch)
2014-03-03 05:35 PST, Hyowon Kim 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hyowon Kim 2014-03-03 04:05:34 PST 
EFL port will use EvasGLContext and EvasGLSurface files in both WK1 and WK2.
And WebCore/platform/graphics/efl is more proper place for them.
Comment 1 Hyowon Kim 2014-03-03 04:20:28 PST 
Created attachment 225642 [details]
Patch
Comment 2 WebKit Commit Bot 2014-03-03 04:22:46 PST 
Attachment 225642 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/efl/EvasGLSurface.h:60:  The parameter name "evasGL" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/platform/graphics/efl/EvasGLContext.h:51:  The parameter name "evasGL" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Hyowon Kim 2014-03-03 05:35:21 PST 
Created attachment 225643 [details]
Patch
Comment 4 Gyuyoung Kim 2014-03-03 23:39:12 PST 
Comment on attachment 225643 [details]
Patch

LGTM.
Comment 5 WebKit Commit Bot 2014-03-04 00:20:50 PST 
Comment on attachment 225643 [details]
Patch

Clearing flags on attachment: 225643

Committed r165043: <http://trac.webkit.org/changeset/165043>
Comment 6 WebKit Commit Bot 2014-03-04 00:20:54 PST 
All reviewed patches have been landed.  Closing bug.