Bug 129597 - [x86] Improve code generation of byte test
Summary: [x86] Improve code generation of byte test
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-02 19:30 PST by Benjamin Poulain
Modified: 2014-03-05 10:50 PST (History)
5 users (show)

See Also:

Attachments
Patch (2.01 KB, patch)
2014-03-02 19:32 PST, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2014-03-02 19:30:55 PST 
[x86] Improve code generation of byte test
Comment 1 Benjamin Poulain 2014-03-02 19:32:25 PST 
Created attachment 225628 [details]
Patch
Comment 2 Benjamin Poulain 2014-03-02 19:36:11 PST 
I have noticed that pattern from the CSS JIT.
Comment 3 Geoffrey Garen 2014-03-03 13:48:58 PST 
Comment on attachment 225628 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2014-03-03 14:22:41 PST 
Comment on attachment 225628 [details]
Patch

Clearing flags on attachment: 225628

Committed r165009: <http://trac.webkit.org/changeset/165009>
Comment 5 WebKit Commit Bot 2014-03-03 14:22:43 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Benjamin Poulain 2014-03-04 10:36:51 PST 
(In reply to comment #6)
> Looks like this was a 1% improvement on DYEBench on some machines.
> 
> https://perf.webkit.org/#mode=charts&chartList=%5B%5B%22mac-mavericks%22%2C%22DoYouEvenBench%2FFull%3ATime%3ATotal%22%5D%2C%5B%22mac-mountainlion%22%2C%22DoYouEvenBench%2FFull%3ATime%3ATotal%22%5D%5D

That's awesome :)