WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
129597
[x86] Improve code generation of byte test
https://bugs.webkit.org/show_bug.cgi?id=129597
Summary
[x86] Improve code generation of byte test
Benjamin Poulain
Reported
2014-03-02 19:30:55 PST
[x86] Improve code generation of byte test
Attachments
Patch
(2.01 KB, patch)
2014-03-02 19:32 PST
,
Benjamin Poulain
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Benjamin Poulain
Comment 1
2014-03-02 19:32:25 PST
Created
attachment 225628
[details]
Patch
Benjamin Poulain
Comment 2
2014-03-02 19:36:11 PST
I have noticed that pattern from the CSS JIT.
Geoffrey Garen
Comment 3
2014-03-03 13:48:58 PST
Comment on
attachment 225628
[details]
Patch r=me
WebKit Commit Bot
Comment 4
2014-03-03 14:22:41 PST
Comment on
attachment 225628
[details]
Patch Clearing flags on attachment: 225628 Committed
r165009
: <
http://trac.webkit.org/changeset/165009
>
WebKit Commit Bot
Comment 5
2014-03-03 14:22:43 PST
All reviewed patches have been landed. Closing bug.
Ryosuke Niwa
Comment 6
2014-03-04 02:11:08 PST
Looks like this was a 1% improvement on DYEBench on some machines.
https://perf.webkit.org/#mode=charts&chartList=%5B%5B%22mac-mavericks%22%2C%22DoYouEvenBench%2FFull%3ATime%3ATotal%22%5D%2C%5B%22mac-mountainlion%22%2C%22DoYouEvenBench%2FFull%3ATime%3ATotal%22%5D%5D
Benjamin Poulain
Comment 7
2014-03-04 10:36:51 PST
(In reply to
comment #6
)
> Looks like this was a 1% improvement on DYEBench on some machines. > >
https://perf.webkit.org/#mode=charts&chartList=%5B%5B%22mac-mavericks%22%2C%22DoYouEvenBench%2FFull%3ATime%3ATotal%22%5D%2C%5B%22mac-mountainlion%22%2C%22DoYouEvenBench%2FFull%3ATime%3ATotal%22%5D%5D
That's awesome :)
Ryosuke Niwa
Comment 8
2014-03-05 10:50:04 PST
Holy shit... this might have been a 15% improvement on Dromaeo's dom-query:
https://perf.webkit.org/#mode=charts&chartList=%5B%5B%22mac-mountainlion%22%2C%22Dromaeo%2Fdom-query%3ARuns%22%5D%2C%5B%22mac-mavericks%22%2C%22Dromaeo%2Fdom-query%3ARuns%22%5D%5D
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug