Bug 129581 - Sort Cocoa platform export files so they merge better
Summary: Sort Cocoa platform export files so they merge better
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-02 14:07 PST by Darin Adler
Modified: 2014-03-03 10:50 PST (History)
2 users (show)

See Also:


Attachments
Patch (85.28 KB, patch)
2014-03-02 14:22 PST, Darin Adler
no flags Details | Formatted Diff | Diff
Patch (78.02 KB, patch)
2014-03-02 14:24 PST, Darin Adler
sam: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2014-03-02 14:07:39 PST
Sort Mac platform export files so they merge better
Comment 1 Darin Adler 2014-03-02 14:22:42 PST
Created attachment 225609 [details]
Patch
Comment 2 Darin Adler 2014-03-02 14:24:50 PST
Created attachment 225610 [details]
Patch
Comment 3 WebKit Commit Bot 2014-03-02 14:27:15 PST
Comment on attachment 225610 [details]
Patch

Rejecting attachment 225610 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 225610, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.appspot.com/results/5278857900851200
Comment 4 Darin Adler 2014-03-02 14:29:56 PST
Committed r164951: <http://trac.webkit.org/changeset/164951>
Comment 5 Tim Horton 2014-03-02 18:56:40 PST
Maybe the style checker should somehow include this?
Comment 6 Darin Adler 2014-03-03 10:50:21 PST
(In reply to comment #5)
> Maybe the style checker should somehow include this?

Good idea. It would be trivial to add a dry run mode to this tool so that it answers the question, “Would this tool change the file?”