WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
129517
[Mac] Extract _data->_thumbnailView checks into a helper function
https://bugs.webkit.org/show_bug.cgi?id=129517
Summary
[Mac] Extract _data->_thumbnailView checks into a helper function
Alexey Proskuryakov
Reported
2014-02-28 16:38:12 PST
Every mouse event handling function has this #if and a surprising check. Move them all into one place.
Attachments
proposed patch
(4.49 KB, patch)
2014-02-28 16:40 PST
,
Alexey Proskuryakov
no flags
Details
Formatted Diff
Diff
with less build fail
(4.53 KB, patch)
2014-02-28 16:55 PST
,
Alexey Proskuryakov
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1
2014-02-28 16:40:16 PST
Created
attachment 225505
[details]
proposed patch
Alexey Proskuryakov
Comment 2
2014-02-28 16:55:58 PST
Created
attachment 225509
[details]
with less build fail
WebKit Commit Bot
Comment 3
2014-02-28 20:59:42 PST
Comment on
attachment 225509
[details]
with less build fail Clearing flags on attachment: 225509 Committed
r164906
: <
http://trac.webkit.org/changeset/164906
>
WebKit Commit Bot
Comment 4
2014-02-28 20:59:44 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug