Bug 129482 - Remove unsupported spelling tests.
Summary: Remove unsupported spelling tests.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Grzegorz Czajkowski
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-28 06:44 PST by Grzegorz Czajkowski
Modified: 2014-03-05 02:30 PST (History)
2 users (show)

See Also:


Attachments
Patch (11.00 KB, patch)
2014-02-28 06:52 PST, Grzegorz Czajkowski
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 (458.91 KB, application/zip)
2014-02-28 07:51 PST, Build Bot
no flags Details
make mac-wk2-ews happy (11.40 KB, patch)
2014-03-03 00:58 PST, Grzegorz Czajkowski
no flags Details | Formatted Diff | Diff
Remove two unsupported spelling tests (8.20 KB, patch)
2014-03-05 01:59 PST, Grzegorz Czajkowski
rniwa: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Grzegorz Czajkowski 2014-02-28 06:44:24 PST
Skip two spelling tests that require spellchecking of multiple words. Currently, neither WebKit port is supporting this feature. Those tests were added by Chromium at r141354.
Comment 1 Grzegorz Czajkowski 2014-02-28 06:52:18 PST
Created attachment 225459 [details]
Patch

I requested review since nonsignificant changes in those tests
Comment 2 Build Bot 2014-02-28 07:51:53 PST
Comment on attachment 225459 [details]
Patch

Attachment 225459 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6495454632083456

New failing tests:
editing/spelling/spelling-exactly-selected-word.html
Comment 3 Build Bot 2014-02-28 07:51:54 PST
Created attachment 225462 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 4 Grzegorz Czajkowski 2014-03-03 00:58:53 PST
Created attachment 225636 [details]
make mac-wk2-ews happy
Comment 5 Ryosuke Niwa 2014-03-05 01:00:53 PST
Can we just remove these tests?
Comment 6 Grzegorz Czajkowski 2014-03-05 01:59:40 PST
Created attachment 225872 [details]
Remove two unsupported spelling tests
Comment 7 Grzegorz Czajkowski 2014-03-05 02:30:10 PST
Committed r165102: <http://trac.webkit.org/changeset/165102>