Bug 129462 - Inspector test dom/dom-search-crash.html times out in release builds
Summary: Inspector test dom/dom-search-crash.html times out in release builds
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: BJ Burg
URL:
Keywords:
Depends on:
Blocks: 129639
  Show dependency treegraph
 
Reported: 2014-02-27 16:31 PST by BJ Burg
Modified: 2014-03-03 16:55 PST (History)
4 users (show)

See Also:


Attachments
the patch (1.34 KB, patch)
2014-03-03 11:29 PST, BJ Burg
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2014-02-27 16:31:05 PST
Failure: http://build.webkit.org/results/Apple%20Mavericks%20Release%20WK1%20(Tests)/r164830%20(3813)/inspector-protocol/dom/dom-search-crash-pretty-diff.html

Seems to be somehow caused by http://trac.webkit.org/changeset/164830. The test passes locally in debug builds of DRT and WKTR, and fails in release builds of both.
Comment 1 BJ Burg 2014-02-27 16:41:15 PST
Committed r164843: <http://trac.webkit.org/changeset/164843>
Comment 2 BJ Burg 2014-02-27 16:43:31 PST
webkit-patch got a little confused.
Comment 3 BJ Burg 2014-03-03 11:29:16 PST
Created attachment 225675 [details]
the patch
Comment 4 BJ Burg 2014-03-03 11:29:52 PST
Waiting for this to go through EWS to make sure it's not obviously flaky.
Comment 5 WebKit Commit Bot 2014-03-03 13:27:39 PST
Comment on attachment 225675 [details]
the patch

Clearing flags on attachment: 225675

Committed r165004: <http://trac.webkit.org/changeset/165004>
Comment 6 WebKit Commit Bot 2014-03-03 13:27:41 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Alexey Proskuryakov 2014-03-03 16:55:41 PST
This test is still failing most of the time, filed bug 129639.