Bug 129461 - [CSS Shapes] Update line segments for ShapeInside only if the new line is wide enough
Summary: [CSS Shapes] Update line segments for ShapeInside only if the new line is wid...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zoltan Horvath
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-27 16:31 PST by Zoltan Horvath
Modified: 2014-02-28 10:09 PST (History)
4 users (show)

See Also:

Attachments
Patch (6.07 KB, patch)
2014-02-27 16:34 PST, Zoltan Horvath 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Horvath 2014-02-27 16:31:02 PST 
Shape-inside can make a line only narrower than the original line width, thus we don't need to update the line/shape segments in fitBelowFloats for every single line inside shape-inside. This patch adds a helper function, which updates the line segments, furthermore it updates the line segments only when the content would fit without the shape.
Comment 1 Zoltan Horvath 2014-02-27 16:34:44 PST 
Created attachment 225427 [details]
Patch
Comment 2 Dave Hyatt 2014-02-28 09:32:28 PST 
Comment on attachment 225427 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2014-02-28 10:09:11 PST 
Comment on attachment 225427 [details]
Patch

Clearing flags on attachment: 225427

Committed r164868: <http://trac.webkit.org/changeset/164868>
Comment 4 WebKit Commit Bot 2014-02-28 10:09:14 PST 
All reviewed patches have been landed.  Closing bug.