Bug 129459 – Build break when disabled CSS_GRID_LAYOUT

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Ryuan Choi]

distcc[8236] ERROR: compile /home/ryuan/.ccache/tmp/CSSValue.tmp.ryuan-desktop2.8226.ii on localhost failed
/workspace/project/webkit/efl-webkit/Source/WebCore/css/CSSValue.cpp: In member function ‘WTF::String WebCore::CSSValue::cssText() const’:
/workspace/project/webkit/efl-webkit/Source/WebCore/css/CSSValue.cpp:250:12: error: enumeration value ‘GridTemplateAreasClass’ not handled in switch [-Werror=switch]
     switch (classType()) {
            ^
/workspace/project/webkit/efl-webkit/Source/WebCore/css/CSSValue.cpp: In member function ‘void WebCore::CSSValue::destroy()’:
/workspace/project/webkit/efl-webkit/Source/WebCore/css/CSSValue.cpp:333:12: error: enumeration value ‘GridTemplateAreasClass’ not handled in switch [-Werror=switch]
     switch (classType()) {
            ^

[Ryuan Choi]

Created attachment 225425 [details]
Patch

[WebKit Commit Bot]

Attachment 225425 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Gyuyoung Kim]

Comment on attachment 225425 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=225425&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests (OOPS!).

Please remove this line before landing.

[Ryuan Choi]

Created attachment 225431 [details]
Patch

[Ryuan Choi]

Committed r164849: <http://trac.webkit.org/changeset/164849>

[Ryuan Choi]

Comment on attachment 225431 [details]
Patch

clearing flags.