Bug 129459 - Build break when disabled CSS_GRID_LAYOUT
Summary: Build break when disabled CSS_GRID_LAYOUT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryuan Choi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-27 16:12 PST by Ryuan Choi
Modified: 2014-02-27 19:26 PST (History)
6 users (show)

See Also:

Attachments
Patch (1.83 KB, patch)
2014-02-27 16:18 PST, Ryuan Choi 		no flags Details | Formatted Diff | Diff
Patch (1.80 KB, patch)
2014-02-27 17:24 PST, Ryuan Choi 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2014-02-27 16:12:45 PST 
distcc[8236] ERROR: compile /home/ryuan/.ccache/tmp/CSSValue.tmp.ryuan-desktop2.8226.ii on localhost failed
/workspace/project/webkit/efl-webkit/Source/WebCore/css/CSSValue.cpp: In member function ‘WTF::String WebCore::CSSValue::cssText() const’:
/workspace/project/webkit/efl-webkit/Source/WebCore/css/CSSValue.cpp:250:12: error: enumeration value ‘GridTemplateAreasClass’ not handled in switch [-Werror=switch]
     switch (classType()) {
            ^
/workspace/project/webkit/efl-webkit/Source/WebCore/css/CSSValue.cpp: In member function ‘void WebCore::CSSValue::destroy()’:
/workspace/project/webkit/efl-webkit/Source/WebCore/css/CSSValue.cpp:333:12: error: enumeration value ‘GridTemplateAreasClass’ not handled in switch [-Werror=switch]
     switch (classType()) {
            ^
Comment 1 Ryuan Choi 2014-02-27 16:18:07 PST 
Created attachment 225425 [details]
Patch
Comment 2 WebKit Commit Bot 2014-02-27 16:19:50 PST 
Attachment 225425 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Gyuyoung Kim 2014-02-27 17:23:36 PST 
Comment on attachment 225425 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=225425&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests (OOPS!).

Please remove this line before landing.
Comment 4 Ryuan Choi 2014-02-27 17:24:59 PST 
Created attachment 225431 [details]
Patch
Comment 5 Ryuan Choi 2014-02-27 19:25:53 PST 
Committed r164849: <http://trac.webkit.org/changeset/164849>
Comment 6 Ryuan Choi 2014-02-27 19:26:14 PST 
Comment on attachment 225431 [details]
Patch

clearing flags.