Bug 129435 - Octane/closure thrashes between flattening dictionaries during global object initialization in a global eval
Summary: Octane/closure thrashes between flattening dictionaries during global object ...
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on: 129490 129699
Blocks:
  Show dependency tree / graph
 
Reported: 2014-02-27 09:42 PST by Filip Pizlo
Modified: 2014-03-04 13:22 PST (History)
11 users (show)

See Also:

Attachments
the patch (5.89 KB, patch)
2014-02-27 09:44 PST, Filip Pizlo 		oliver: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2014-02-27 09:42:01 PST 
If the global object is already a dictionary even before we start adding things, then we should leave it that way.
Comment 1 Filip Pizlo 2014-02-27 09:44:17 PST 
Created attachment 225386 [details]
the patch
Comment 2 Filip Pizlo 2014-02-27 10:29:08 PST 
Landed in http://trac.webkit.org/changeset/164812
Comment 3 Csaba Osztrogonác 2014-02-28 08:59:46 PST 
(In reply to comment #2)
> Landed in http://trac.webkit.org/changeset/164812

It caused regression on 32 bit platforms, see https://bugs.webkit.org/show_bug.cgi?id=129490 for details.
Comment 4 WebKit Commit Bot 2014-03-04 13:22:41 PST 
Re-opened since this is blocked by bug 129699