Bug 129367 - Remove unused InspectorCounters.
Summary: Remove unused InspectorCounters.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-25 23:59 PST by Andreas Kling
Modified: 2014-02-26 12:10 PST (History)
12 users (show)

See Also:


Attachments
Patch (32.65 KB, patch)
2014-02-26 00:05 PST, Andreas Kling
no flags Details | Formatted Diff | Diff
Patch (33.65 KB, patch)
2014-02-26 00:28 PST, Andreas Kling
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 (452.23 KB, application/zip)
2014-02-26 01:32 PST, Build Bot
no flags Details
Patch (33.54 KB, patch)
2014-02-26 02:24 PST, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2014-02-25 23:59:13 PST
This was only used by the Chromium inspector and is squatting on hot paths.
Comment 1 Andreas Kling 2014-02-26 00:05:31 PST
Created attachment 225231 [details]
Patch
Comment 2 Andreas Kling 2014-02-26 00:28:46 PST
Created attachment 225233 [details]
Patch

Try to appease windows bot.
Comment 3 Build Bot 2014-02-26 01:32:17 PST
Comment on attachment 225233 [details]
Patch

Attachment 225233 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4802150353862656

New failing tests:
svg/masking/mask-negative-scale.svg
svg/animations/svglength-element-removed-crash.svg
Comment 4 Build Bot 2014-02-26 01:32:20 PST
Created attachment 225242 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 5 Andreas Kling 2014-02-26 02:24:09 PST
Created attachment 225245 [details]
Patch
Comment 6 WebKit Commit Bot 2014-02-26 12:10:16 PST
Comment on attachment 225245 [details]
Patch

Clearing flags on attachment: 225245

Committed r164735: <http://trac.webkit.org/changeset/164735>
Comment 7 WebKit Commit Bot 2014-02-26 12:10:19 PST
All reviewed patches have been landed.  Closing bug.