Bug 129354 - [iOS][WK2] Split the rects/scale updates in 3 internally consistent groups
Summary: [iOS][WK2] Split the rects/scale updates in 3 internally consistent groups
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-25 18:16 PST by Benjamin Poulain
Modified: 2014-02-25 23:38 PST (History)
0 users

See Also:

Attachments
Patch (61.95 KB, patch)
2014-02-25 18:34 PST, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Patch (61.43 KB, patch)
2014-02-25 22:57 PST, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Patch (60.96 KB, patch)
2014-02-25 23:31 PST, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2014-02-25 18:16:29 PST 
[iOS][WK2] Split the rects/scale updates in 3 internally consistent groups
Comment 1 Benjamin Poulain 2014-02-25 18:34:02 PST 
Created attachment 225209 [details]
Patch
Comment 2 Sam Weinig 2014-02-25 18:41:22 PST 
Comment on attachment 225209 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=225209&action=review

> Source/WebKit2/UIProcess/ios/WKContentView.mm:153
> +    if (!isStableState && abs(scale - _page->displayedContentScale()) < 0.0005) {

Can we put 0.0005 into a constant with a good name?

> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:362
> +        // FIXME: patch separately.

What does this mean?
Comment 3 Tim Horton 2014-02-25 18:52:11 PST 
Comment on attachment 225209 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=225209&action=review

> Source/WebKit2/Scripts/webkit2/messages.py:224
> +        'VisibleContentRectUpdateInfo',

weird that this doesn't have a namespace, isn't it?
Comment 4 Benjamin Poulain 2014-02-25 22:57:01 PST 
Created attachment 225224 [details]
Patch
Comment 5 Benjamin Poulain 2014-02-25 23:31:18 PST 
Created attachment 225226 [details]
Patch
Comment 6 Benjamin Poulain 2014-02-25 23:38:00 PST 
Comment on attachment 225226 [details]
Patch

Clearing flags on attachment: 225226

Committed r164702: <http://trac.webkit.org/changeset/164702>
Comment 7 Benjamin Poulain 2014-02-25 23:38:01 PST 
All reviewed patches have been landed.  Closing bug.