Bug 129341 - JSDOMPromise methods should acquire VM lock before calling into JS
Summary: JSDOMPromise methods should acquire VM lock before calling into JS
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
Depends on:
Blocks: 129265
  Show dependency treegraph
Reported: 2014-02-25 15:23 PST by Mark Lam
Modified: 2014-04-24 16:46 PDT (History)
3 users (show)

See Also:

the patch. (3.17 KB, patch)
2014-02-25 15:26 PST, Mark Lam
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2014-02-25 15:23:12 PST
Some crypto tests were failing after r164627: <http://trac.webkit.org/r164627> because the resolve() and reject() methods were calling into JS VM without using an entry shim.  r164627 added assertions that caught this issue.

Patch coming.
Comment 1 Mark Lam 2014-02-25 15:26:33 PST
Created attachment 225191 [details]
the patch.
Comment 2 Geoffrey Garen 2014-02-25 15:43:29 PST
Comment on attachment 225191 [details]
the patch.

Comment 3 Mark Lam 2014-02-25 15:48:51 PST
Thanks.  Landed in r164679: <http://trac.webkit.org/r164679>.
Comment 4 Darin Adler 2014-04-24 16:46:02 PDT
Moving all JavaScriptGlue bugs to JavaScriptCore. The JavaScriptGlue framework itself is long gone. And most of the more recent bugs put in this component were put there by people who thought this was for some other aspect of “JavaScript glue” and have nothing to do with the actual original reason for the existence of this component, which was an OS-X-only framework named JavaScriptGlue.