Bug 129273 - Break out ImageControls style into an external stylesheet
Summary: Break out ImageControls style into an external stylesheet
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-24 13:41 PST by Brady Eidson
Modified: 2014-02-24 13:54 PST (History)
7 users (show)

See Also:

Attachments
Patch v1 (11.42 KB, patch)
2014-02-24 13:44 PST, Brady Eidson 		jer.noble: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2014-02-24 13:41:29 PST 
Break out ImageControls style into an external stylesheet
Comment 1 Brady Eidson 2014-02-24 13:44:32 PST 
Created attachment 225093 [details]
Patch v1
Comment 2 Jer Noble 2014-02-24 13:46:15 PST 
Comment on attachment 225093 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=225093&action=review

r=me with nit.

> Source/WebCore/html/shadow/mac/ImageControlsRootElementMac.cpp:33
> +#include "Event.h"
> +#include "EventNames.h"
> +#include "Page.h"

Are these really necessary?
Comment 3 Brady Eidson 2014-02-24 13:47:36 PST 
(In reply to comment #2)
> (From update of attachment 225093 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=225093&action=review
> 
> r=me with nit.
> 
> > Source/WebCore/html/shadow/mac/ImageControlsRootElementMac.cpp:33
> > +#include "Event.h"
> > +#include "EventNames.h"
> > +#include "Page.h"
> 
> Are these really necessary?

Nope, sorry - leftovers from a patch split-up
Comment 4 Brady Eidson 2014-02-24 13:54:06 PST 
http://trac.webkit.org/changeset/164606