Bug 129245 - [GTK] Remove unneeded method webkitWebViewBaseRequestExitFullScreen
Summary: [GTK] Remove unneeded method webkitWebViewBaseRequestExitFullScreen
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: Gtk
Depends on:
Reported: 2014-02-24 00:58 PST by Carlos Garcia Campos
Modified: 2014-02-24 01:26 PST (History)
5 users (show)

See Also:

Patch (2.87 KB, patch)
2014-02-24 01:01 PST, Carlos Garcia Campos
svillar: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2014-02-24 00:58:54 PST
It's a semi-private method but that it's only used once in WebKitWebViewBase.cpp and it contains a single line.
Comment 1 Carlos Garcia Campos 2014-02-24 01:01:13 PST
Created attachment 225032 [details]
Comment 2 WebKit Commit Bot 2014-02-24 01:02:45 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Sergio Villar Senin 2014-02-24 01:13:10 PST
Comment on attachment 225032 [details]

Let's do it.

BTW what about also replacing the switch by an if statement in webkitWebViewBaseKeyPressEvent? Looks like abusing the syntax to me.
Comment 4 Carlos Garcia Campos 2014-02-24 01:26:03 PST
Committed r164578: <http://trac.webkit.org/changeset/164578>