Bug 129168 - Web Inspector: remove old inspector tests that cannot be ported
Summary: Web Inspector: remove old inspector tests that cannot be ported
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: BJ Burg
Depends on:
Reported: 2014-02-21 13:56 PST by BJ Burg
Modified: 2014-02-21 16:23 PST (History)
8 users (show)

See Also:

patch (1.17 MB, patch)
2014-02-21 14:34 PST, BJ Burg
timothy: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2014-02-21 13:56:20 PST
411 is a lot of skipped tests. I think maybe 100 at most (say, debugger tests) should be kept and evaluated more carefully. There are a lot of UI specific tests.
Comment 1 BJ Burg 2014-02-21 14:34:36 PST
Created attachment 224910 [details]
Comment 2 Timothy Hatcher 2014-02-21 15:05:24 PST
Comment on attachment 224910 [details]

Comment 3 WebKit Commit Bot 2014-02-21 16:08:14 PST
Comment on attachment 224910 [details]

Rejecting attachment 224910 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 224910, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
    -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 164509 = 7af1393f6a635141131eadb1d8d4349b75de253c
r164510 = eafb76a13ed3e62e4a85ec458823a344a7b6c25a
r164511 = f9e0215cbe9864209a3399d88ad0f2053be4fb3e
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-queues.appspot.com/results/5544649972252672
Comment 4 BJ Burg 2014-02-21 16:23:41 PST
Committed r164515: <http://trac.webkit.org/changeset/164515>