Bug 129125 - FTL may not see a compact_unwind section if there weren't any stackmaps
Summary: FTL may not see a compact_unwind section if there weren't any stackmaps
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 112840
  Show dependency tree / graph
 
Reported: 2014-02-20 15:45 PST by Filip Pizlo
Modified: 2014-02-20 16:03 PST (History)
10 users (show)

See Also:

Attachments
the patch (5.14 KB, patch)
2014-02-20 15:47 PST, Filip Pizlo 		ggaren: review+
Details | Formatted Diff | Diff
llvm patch (6.77 KB, patch)
2014-02-20 15:48 PST, Filip Pizlo 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2014-02-20 15:45:17 PST 
It's theoretically possible for there to not be any stackmaps, so we should guard against it.
Comment 1 Filip Pizlo 2014-02-20 15:47:57 PST 
Created attachment 224805 [details]
the patch
Comment 2 Filip Pizlo 2014-02-20 15:48:26 PST 
Created attachment 224806 [details]
llvm patch
Comment 3 Geoffrey Garen 2014-02-20 15:53:47 PST 
Comment on attachment 224805 [details]
the patch

r=me
Comment 4 Filip Pizlo 2014-02-20 15:55:05 PST 
Landed in http://trac.webkit.org/changeset/164456
Comment 5 Filip Pizlo 2014-02-20 16:03:43 PST 
LLVM side of this landed in http://llvm.org/viewvc/llvm-project?view=revision&revision=201826