Bug 129092 - [CSS Grid Layout] Check default getComputedStyle() return values for grid properties
Summary: [CSS Grid Layout] Check default getComputedStyle() return values for grid pro...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sergio Villar Senin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-20 02:17 PST by Sergio Villar Senin
Modified: 2014-02-26 09:55 PST (History)
9 users (show)

See Also:

Attachments
Patch (4.95 KB, patch)
2014-02-20 10:24 PST, Sergio Villar Senin 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion (507.92 KB, application/zip)
2014-02-20 11:46 PST, Build Bot 		no flags Details
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion (509.70 KB, application/zip)
2014-02-20 12:46 PST, Build Bot 		no flags Details
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 (523.64 KB, application/zip)
2014-02-20 12:56 PST, Build Bot 		no flags Details
Patch (9.00 KB, patch)
2014-02-24 01:08 PST, Sergio Villar Senin 		no flags Details | Formatted Diff | Diff
Patch (8.08 KB, patch)
2014-02-25 13:12 PST, Sergio Villar Senin 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Villar Senin 2014-02-20 02:17:48 PST 
We need to update: 

fast/css/getComputedStyle/computed-style.html
fast/css/getComputedStyle/computed-style-without-renderer.html
Comment 1 Sergio Villar Senin 2014-02-20 10:24:00 PST 
Created attachment 224769 [details]
Patch
Comment 2 Build Bot 2014-02-20 11:46:15 PST 
Comment on attachment 224769 [details]
Patch

Attachment 224769 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4725809893867520

New failing tests:
svg/css/getComputedStyle-basic.xhtml
Comment 3 Build Bot 2014-02-20 11:46:17 PST 
Created attachment 224778 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 4 Build Bot 2014-02-20 12:46:28 PST 
Comment on attachment 224769 [details]
Patch

Attachment 224769 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6736472392597504

New failing tests:
svg/css/getComputedStyle-basic.xhtml
Comment 5 Build Bot 2014-02-20 12:46:30 PST 
Created attachment 224784 [details]
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-08  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 6 Build Bot 2014-02-20 12:56:31 PST 
Comment on attachment 224769 [details]
Patch

Attachment 224769 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6722674675941376

New failing tests:
svg/css/getComputedStyle-basic.xhtml
Comment 7 Build Bot 2014-02-20 12:56:34 PST 
Created attachment 224786 [details]
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-11  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 8 Sergio Villar Senin 2014-02-24 01:08:24 PST 
Created attachment 225037 [details]
Patch
Comment 9 Sergio Villar Senin 2014-02-25 13:12:53 PST 
Created attachment 225176 [details]
Patch
Comment 10 WebKit Commit Bot 2014-02-26 09:55:15 PST 
Comment on attachment 225176 [details]
Patch

Clearing flags on attachment: 225176

Committed r164719: <http://trac.webkit.org/changeset/164719>
Comment 11 WebKit Commit Bot 2014-02-26 09:55:19 PST 
All reviewed patches have been landed.  Closing bug.