Bug 128920 - [GTK] Mark view source mode methods as deprecated
Summary: [GTK] Mark view source mode methods as deprecated
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2014-02-17 11:25 PST by Carlos Garcia Campos
Modified: 2014-02-24 23:45 PST (History)
5 users (show)

See Also:

Patch (6.75 KB, patch)
2014-02-24 01:31 PST, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff
Updated patch (7.68 KB, patch)
2014-02-24 02:58 PST, Carlos Garcia Campos
mrobinson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2014-02-17 11:25:52 PST
They don't do anything since r164235. All possible solutions I can think of to implement this should be done in the application side. So, I think it's better to deprecated instead of trying to figure out how to re-implement them in webkit without the view source mode in webcore.
Comment 1 Carlos Garcia Campos 2014-02-24 01:31:16 PST
Created attachment 225044 [details]
Comment 2 WebKit Commit Bot 2014-02-24 01:34:13 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Carlos Garcia Campos 2014-02-24 02:58:02 PST
Created attachment 225049 [details]
Updated patch

Forgot to add deprecation guards in public header
Comment 4 Carlos Garcia Campos 2014-02-24 23:45:56 PST
Committed r164634: <http://trac.webkit.org/changeset/164634>