Bug 128917 - Turn the history client into a fancy API::HistoryClient abstract base class
Summary: Turn the history client into a fancy API::HistoryClient abstract base class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-17 10:48 PST by Anders Carlsson
Modified: 2014-02-17 11:03 PST (History)
1 user (show)

See Also:

Attachments
Patch (28.08 KB, patch)
2014-02-17 10:50 PST, Anders Carlsson 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2014-02-17 10:48:03 PST 
Turn the history client into a fancy API::HistoryClient abstract base class
Comment 1 Anders Carlsson 2014-02-17 10:50:04 PST 
Created attachment 224396 [details]
Patch
Comment 2 WebKit Commit Bot 2014-02-17 10:52:25 PST 
Attachment 224396 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/API/C/WKContext.cpp:29:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2014-02-17 10:56:25 PST 
Comment on attachment 224396 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=224396&action=review

r=me though there's a disgusting amount of asterisks in this code. :|

> Source/WebKit2/UIProcess/WebContext.h:223
> +    API::HistoryClient& historyClient() { return *m_historyClient; }

I'd use this accessor instead of accessing m_historyClient now, since that lets you use . instead of ->
Comment 4 Anders Carlsson 2014-02-17 11:03:35 PST 
Committed r164230: <http://trac.webkit.org/changeset/164230>