Bug 128900 - Fix the CLoop build after r163760
Summary: Fix the CLoop build after r163760
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 128505
  Show dependency tree / graph
 
Reported: 2014-02-17 04:36 PST by Dániel Bátyai
Modified: 2014-02-17 05:18 PST (History)
5 users (show)

See Also:

Attachments
Proposed fix (979 bytes, patch)
2014-02-17 04:36 PST, Dániel Bátyai 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dániel Bátyai 2014-02-17 04:36:21 PST 
Undefined symbols for architecture x86_64:
  "__ZN3JSC7JSValue6encodeES0_", referenced from:
      _callToJavaScript in LLIntThunks.o
      _callToNativeFunction in LLIntThunks.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

including Operations.h didn't help, that's why JSCJSValueInlines.h needed to be included
Comment 1 Dániel Bátyai 2014-02-17 04:36:55 PST 
Created attachment 224357 [details]
Proposed fix
Comment 2 Csaba Osztrogonác 2014-02-17 04:49:27 PST 
Comment on attachment 224357 [details]
Proposed fix

r=me
Comment 3 WebKit Commit Bot 2014-02-17 05:18:22 PST 
Comment on attachment 224357 [details]
Proposed fix

Clearing flags on attachment: 224357

Committed r164217: <http://trac.webkit.org/changeset/164217>
Comment 4 WebKit Commit Bot 2014-02-17 05:18:24 PST 
All reviewed patches have been landed.  Closing bug.