Bug 128897 - Move inheriting method to the superclass in the JavaScript media controls
Summary: Move inheriting method to the superclass in the JavaScript media controls
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Xabier Rodríguez Calvar
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-17 03:20 PST by Xabier Rodríguez Calvar
Modified: 2014-02-18 02:17 PST (History)
6 users (show)

See Also:

Attachments
Patch (3.90 KB, patch)
2014-02-17 03:23 PST, Xabier Rodríguez Calvar 		no flags Details | Formatted Diff | Diff
Patch (3.88 KB, patch)
2014-02-17 09:31 PST, Xabier Rodríguez Calvar 		no flags Details | Formatted Diff | Diff
Patch (3.88 KB, patch)
2014-02-18 01:37 PST, Xabier Rodríguez Calvar 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xabier Rodríguez Calvar 2014-02-17 03:20:22 PST 
Move inheriting method to the superclass in the JavaScript media controls
Comment 1 Xabier Rodríguez Calvar 2014-02-17 03:23:51 PST 
Created attachment 224350 [details]
Patch
Comment 2 Jer Noble 2014-02-17 08:33:48 PST 
Comment on attachment 224350 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=224350&action=review

> Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:100
> +    inheritTo: function(child) {

I'm not a huge fan of "inheritTo()".  How about "extend()"?
Comment 3 Xabier Rodríguez Calvar 2014-02-17 08:48:17 PST 
(In reply to comment #2)
> (From update of attachment 224350 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=224350&action=review
> 
> > Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:100
> > +    inheritTo: function(child) {
> 
> I'm not a huge fan of "inheritTo()".  How about "extend()"?

Awesome :) Actually I didn't like it either but at that moment my head couldn't work out anything better. Good, so I'll commit that change tomorrow morning.
Comment 4 Xabier Rodríguez Calvar 2014-02-17 09:31:08 PST 
Created attachment 224386 [details]
Patch
Comment 5 Xabier Rodríguez Calvar 2014-02-18 01:13:52 PST 
Comment on attachment 224386 [details]
Patch

Committing as per Jer Noble's previous r+
Comment 6 WebKit Commit Bot 2014-02-18 01:15:07 PST 
Comment on attachment 224386 [details]
Patch

Rejecting attachment 224386 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 224386, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.

Full output: http://webkit-queues.appspot.com/results/6614922536419328
Comment 7 Xabier Rodríguez Calvar 2014-02-18 01:37:08 PST 
Created attachment 224481 [details]
Patch
Comment 8 Xabier Rodríguez Calvar 2014-02-18 01:38:15 PST 
Comment on attachment 224481 [details]
Patch

Committing as per r+ from Jer Noble (now in the ChangeLog)
Comment 9 WebKit Commit Bot 2014-02-18 02:17:10 PST 
Comment on attachment 224481 [details]
Patch

Clearing flags on attachment: 224481

Committed r164279: <http://trac.webkit.org/changeset/164279>
Comment 10 WebKit Commit Bot 2014-02-18 02:17:13 PST 
All reviewed patches have been landed.  Closing bug.