Bug 128897 – Move inheriting method to the superclass in the JavaScript media controls

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Xabier Rodríguez Calvar]

Move inheriting method to the superclass in the JavaScript media controls

[Xabier Rodríguez Calvar]

Created attachment 224350 [details]
Patch

[Jer Noble]

Comment on attachment 224350 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=224350&action=review

> Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:100
> +    inheritTo: function(child) {

I'm not a huge fan of "inheritTo()".  How about "extend()"?

[Xabier Rodríguez Calvar]

(In reply to comment #2)
> (From update of attachment 224350 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=224350&action=review
> 
> > Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:100
> > +    inheritTo: function(child) {
> 
> I'm not a huge fan of "inheritTo()".  How about "extend()"?

Awesome :) Actually I didn't like it either but at that moment my head couldn't work out anything better. Good, so I'll commit that change tomorrow morning.

[Xabier Rodríguez Calvar]

Created attachment 224386 [details]
Patch

[Xabier Rodríguez Calvar]

Comment on attachment 224386 [details]
Patch

Committing as per Jer Noble's previous r+

[WebKit Commit Bot]

Comment on attachment 224386 [details]
Patch

Rejecting attachment 224386 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 224386, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.

Full output: http://webkit-queues.appspot.com/results/6614922536419328

[Xabier Rodríguez Calvar]

Created attachment 224481 [details]
Patch

[Xabier Rodríguez Calvar]

Comment on attachment 224481 [details]
Patch

Committing as per r+ from Jer Noble (now in the ChangeLog)

[WebKit Commit Bot]

Comment on attachment 224481 [details]
Patch

Clearing flags on attachment: 224481

Committed r164279: <http://trac.webkit.org/changeset/164279>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.