WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
128885
Stop using PLATFORM(MAC) in Source except where it means “OS X but not iOS”
https://bugs.webkit.org/show_bug.cgi?id=128885
Summary
Stop using PLATFORM(MAC) in Source except where it means “OS X but not iOS”
mitz
Reported
2014-02-16 11:54:47 PST
Fix a few more instances of PLATFORM(MAC) in Source/WebCore and update all relevant instances in Source/WebKit2/WebProcess.
Attachments
Use PLATFORM(COCOA), add !PLATFORM(IOS), etc.
(73.55 KB, patch)
2014-02-16 12:09 PST
,
mitz
andersca
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
mitz
Comment 1
2014-02-16 12:09:22 PST
Created
attachment 224320
[details]
Use PLATFORM(COCOA), add !PLATFORM(IOS), etc.
Anders Carlsson
Comment 2
2014-02-16 12:30:52 PST
Comment on
attachment 224320
[details]
Use PLATFORM(COCOA), add !PLATFORM(IOS), etc. View in context:
https://bugs.webkit.org/attachment.cgi?id=224320&action=review
> Source/WebCore/loader/FrameLoaderClient.h:54 > class NSCachedURLResponse; > class NSView;
Should switch this to OBJC_CLASS while you're at it.
mitz
Comment 3
2014-02-16 12:33:41 PST
Committed <
http://trac.webkit.org/r164192
>.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug