Bug 128870 - HTMLTextFormControlElement::subtreeHasChanged should be called before updating selection
Summary: HTMLTextFormControlElement::subtreeHasChanged should be called before updatin...
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
Depends on:
Reported: 2014-02-15 01:54 PST by Ryosuke Niwa
Modified: 2014-02-15 16:31 PST (History)
6 users (show)

See Also:

Cleanup (6.16 KB, patch)
2014-02-15 02:01 PST, Ryosuke Niwa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2014-02-15 01:54:47 PST
In order to resolve the bug 128806, it's crucial to keep value() of HTMLTextFromControlElement's up-to-date
when FrameSelection::setSelection tries to update its selection caches.
Comment 1 Ryosuke Niwa 2014-02-15 02:01:51 PST
Created attachment 224294 [details]
Comment 2 Ryosuke Niwa 2014-02-15 03:21:08 PST
Turns out we don't need this change for the bug 128806 but this is probably a good refactoring anyways.
Comment 3 Ryosuke Niwa 2014-02-15 16:31:22 PST
Comment on attachment 224294 [details]

Clearing flags on attachment: 224294

Committed r164183: <http://trac.webkit.org/changeset/164183>
Comment 4 Ryosuke Niwa 2014-02-15 16:31:24 PST
All reviewed patches have been landed.  Closing bug.