Bug 128826 - [EFL][WK2] Stop calling mktemp(3).
Summary: [EFL][WK2] Stop calling mktemp(3).
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Raphael Kubo da Costa (:rakuco)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-14 10:41 PST by Raphael Kubo da Costa (:rakuco)
Modified: 2014-02-15 13:11 PST (History)
5 users (show)

See Also:

Attachments
Patch (5.40 KB, patch)
2014-02-14 10:44 PST, Raphael Kubo da Costa (:rakuco) 		gyuyoung.kim: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Kubo da Costa (:rakuco) 2014-02-14 10:41:28 PST 
[EFL][WK2] Stop calling mktemp(3).
Comment 1 Raphael Kubo da Costa (:rakuco) 2014-02-14 10:44:18 PST 
Created attachment 224231 [details]
Patch
Comment 2 WebKit Commit Bot 2014-02-14 10:45:27 PST 
Attachment 224231 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_download_job.cpp:32:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Raphael Kubo da Costa (:rakuco) 2014-02-14 10:46:13 PST 
(In reply to comment #2)
> Attachment 224231 [details] did not pass style-queue:
> 
> 
> ERROR: Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_download_job.cpp:32:  Alphabetical sorting problem.  [build/include_order] [4]

This is unrelated and should be ignored: those sys/* includes are normally expected to come before the other ones.
Comment 4 Gyuyoung Kim 2014-02-14 16:52:38 PST 
Comment on attachment 224231 [details]
Patch

It looks this is more secure than before. LGTM
Comment 5 Raphael Kubo da Costa (:rakuco) 2014-02-15 13:11:14 PST 
Committed r164179: <http://trac.webkit.org/changeset/164179>