Bug 128679 - Cleanup mac/mac-wk1/mac-wk2 TestExpectations a little bit
Summary: Cleanup mac/mac-wk1/mac-wk2 TestExpectations a little bit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-12 11:59 PST by Brady Eidson
Modified: 2014-02-12 13:33 PST (History)
2 users (show)

See Also:


Attachments
Patch v1 (10.99 KB, patch)
2014-02-12 12:02 PST, Brady Eidson
ap: review+
beidson: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2014-02-12 11:59:22 PST
Cleanup mac/mac-wk1/mac-wk2 TestExpectations a little bit

Mainly, tests disabled in "mac" but re-enabled in "mac-wk2" should *only* be disabled in mac-wk1 so mac-wk2 doesn't have to deal with them.
Comment 1 Brady Eidson 2014-02-12 12:02:13 PST
Created attachment 223991 [details]
Patch v1
Comment 2 Alexey Proskuryakov 2014-02-12 12:03:23 PST
Comment on attachment 223991 [details]
Patch v1 

rs=me, very nice!

I suggest waiting for EWS to become green.
Comment 3 Brady Eidson 2014-02-12 12:04:29 PST
Comment on attachment 223991 [details]
Patch v1 

cq+'ing so it can land if EWS approves.
Comment 4 Brady Eidson 2014-02-12 12:05:56 PST
Nevermind the commit queue - I'm informed it doesn't wait for EWS.  (WHAT?)

I'll land later after EWS approves.
Comment 5 Brady Eidson 2014-02-12 13:33:19 PST
http://trac.webkit.org/changeset/163981