WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
128654
CopiedBlock::pin can call into fastFree while forbidden
https://bugs.webkit.org/show_bug.cgi?id=128654
Summary
CopiedBlock::pin can call into fastFree while forbidden
Mark Hahnenberg
Reported
2014-02-11 22:10:54 PST
...
Attachments
Patch
(2.14 KB, patch)
2014-02-20 12:12 PST
,
Mark Hahnenberg
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1
2014-02-12 09:19:14 PST
This is probably due to the fact that a FullCollection that skips copying doesn't clear the CopyWorkList of the all the surviving CopiedBlocks because we now only call didSurviveGC() at the beginning of FullCollections. EdenCollections always do copying, therefore they always clear all CopyWorkLists. The fix is probably to call didSurviveGC() for all surviving CopiedBlocks at the end of FullCollections as well at the beginning.
Mark Hahnenberg
Comment 2
2014-02-20 12:12:17 PST
Created
attachment 224781
[details]
Patch
WebKit Commit Bot
Comment 3
2014-02-20 14:49:53 PST
Comment on
attachment 224781
[details]
Patch Clearing flags on attachment: 224781 Committed
r164448
: <
http://trac.webkit.org/changeset/164448
>
WebKit Commit Bot
Comment 4
2014-02-20 14:49:54 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug