Bug 128648 - Fix assertions and incorrect codegen for CompareEq(ObjectOrOther:, Object:)
Summary: Fix assertions and incorrect codegen for CompareEq(ObjectOrOther:, Object:)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 112840
  Show dependency tree / graph
 
Reported: 2014-02-11 20:13 PST by Filip Pizlo
Modified: 2014-02-11 20:19 PST (History)
10 users (show)

See Also:

Attachments
the patch (1.52 KB, patch)
2014-02-11 20:15 PST, Filip Pizlo 		mark.lam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2014-02-11 20:13:55 PST 
We did CompareEq(Object:, ObjectOrOther:) correctly but the flipped version wrong.
Comment 1 Filip Pizlo 2014-02-11 20:15:26 PST 
Created attachment 223935 [details]
the patch
Comment 2 Mark Lam 2014-02-11 20:17:20 PST 
Comment on attachment 223935 [details]
the patch

r=me
Comment 3 Filip Pizlo 2014-02-11 20:18:25 PST 
I'll land!
Comment 4 Filip Pizlo 2014-02-11 20:19:56 PST 
Landed in http://trac.webkit.org/changeset/163938