Bug 128544 - REGRESSION(r163660-r163664): js/dom/stack-trace.html fails
Summary: REGRESSION(r163660-r163664): js/dom/stack-trace.html fails
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P1 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-02-10 10:43 PST by Alexey Proskuryakov
Modified: 2014-02-10 15:51 PST (History)
3 users (show)

See Also:

Attachments
fixed the test to be more resilient to stack usage changes. (38.78 KB, patch)
2014-02-10 15:38 PST, Mark Lam 		mark.lam: review-
Details | Formatted Diff | Diff
patch 2. (38.79 KB, patch)
2014-02-10 15:41 PST, Mark Lam 		ap: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Alexey Proskuryakov 2014-02-10 10:46:20 PST 
Updated TestExpectations in <http://trac.webkit.org/r163798>.
Comment 2 Radar WebKit Bug Importer 2014-02-10 11:41:59 PST 
<rdar://problem/16027877>
Comment 3 Mark Lam 2014-02-10 13:03:08 PST 
Note: this test does not fail for release builds.

The reason is because the issue lies in the debug build using a different amount of stack than a release build.  As a result, it encounters a stack overflow error at a different place.  I'll have to think about how we can make the test resilient to this kind of difference in stack usage rate.
Comment 4 Geoffrey Garen 2014-02-10 14:13:14 PST 
I would change the test just to dump the top portion of the backtrace.
Comment 5 Mark Lam 2014-02-10 14:18:28 PST 
(In reply to comment #4)
> I would change the test just to dump the top portion of the backtrace.

It already does.  However, the recursive parts (repeated in the stack trace) are:

    eval at [native code]                            <== Release build overflows here.
    selfRecursive3 at stack-trace.js:72:9
    at eval code                                        <== Debug build overflows here.

To fix this, I’m adding some facility to the test to check for a recursive pattern in the top part of the stack trace.  The test will pass the above if the top of the stack trace shows a repeated pattern that is expected no matter which line of the repeated pattern that the stack trace ends in.
Comment 6 Mark Lam 2014-02-10 15:38:22 PST 
Created attachment 223754 [details]
fixed the test to be more resilient to stack usage changes.
Comment 7 Mark Lam 2014-02-10 15:39:24 PST 
Comment on attachment 223754 [details]
fixed the test to be more resilient to stack usage changes.

need to fix a tab.
Comment 8 Mark Lam 2014-02-10 15:41:52 PST 
Created attachment 223756 [details]
patch 2.
Comment 9 Mark Lam 2014-02-10 15:51:11 PST 
Thanks for the review.  Landed in r163829: <http://trac.webkit.org/r163829>.