Bug 128466 - Manage ShadowData through std::unique_ptr
Summary: Manage ShadowData through std::unique_ptr
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
Depends on:
Blocks: 128007
  Show dependency treegraph
Reported: 2014-02-08 12:28 PST by Zan Dobersek
Modified: 2014-02-09 04:06 PST (History)
11 users (show)

See Also:

Patch (22.50 KB, patch)
2014-02-08 12:29 PST, Zan Dobersek
no flags Details | Formatted Diff | Diff
Patch for landing (22.48 KB, patch)
2014-02-09 02:58 PST, Zan Dobersek
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2014-02-08 12:28:45 PST
Manage ShadowData through std::unique_ptr
Comment 1 Zan Dobersek 2014-02-08 12:29:55 PST
Created attachment 223576 [details]
Comment 2 Andreas Kling 2014-02-09 02:28:56 PST
Comment on attachment 223576 [details]

r=me, though it might be good to let EWS chew on it.
Comment 3 Zan Dobersek 2014-02-09 02:58:33 PST
Created attachment 223624 [details]
Patch for landing

Running it through EWS.
Comment 4 Zan Dobersek 2014-02-09 04:01:46 PST
The EWSs are happy, so I'll land this.
Comment 5 Zan Dobersek 2014-02-09 04:06:05 PST
Comment on attachment 223624 [details]
Patch for landing

Clearing flags on attachment: 223624

Committed r163751: <http://trac.webkit.org/changeset/163751>
Comment 6 Zan Dobersek 2014-02-09 04:06:13 PST
All reviewed patches have been landed.  Closing bug.