WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
128086
RenderSVGInlineText::computeNewScaledFontForStyle() should take references.
https://bugs.webkit.org/show_bug.cgi?id=128086
Summary
RenderSVGInlineText::computeNewScaledFontForStyle() should take references.
Andreas Kling
Reported
2014-02-02 16:12:19 PST
RenderSVGInlineText::computeNewScaledFontForStyle() should take references.
Attachments
Patch
(14.75 KB, patch)
2014-02-02 16:12 PST
,
Andreas Kling
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Andreas Kling
Comment 1
2014-02-02 16:12:46 PST
Created
attachment 222943
[details]
Patch
Darin Adler
Comment 2
2014-02-02 16:16:15 PST
Comment on
attachment 222943
[details]
Patch Great changes. I made some of these same changes in my tree today. Can we use a type more specific than RenderObject for any of this?
Andreas Kling
Comment 3
2014-02-02 16:23:13 PST
(In reply to
comment #2
)
> Can we use a type more specific than RenderObject for any of this?
Alas, this codepath is used by both text and element renderers at the moment.
WebKit Commit Bot
Comment 4
2014-02-02 16:59:02 PST
Comment on
attachment 222943
[details]
Patch Clearing flags on attachment: 222943 Committed
r163276
: <
http://trac.webkit.org/changeset/163276
>
WebKit Commit Bot
Comment 5
2014-02-02 16:59:05 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug