Bug 128086 - RenderSVGInlineText::computeNewScaledFontForStyle() should take references.
Summary: RenderSVGInlineText::computeNewScaledFontForStyle() should take references.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-02 16:12 PST by Andreas Kling
Modified: 2014-02-02 16:59 PST (History)
11 users (show)

See Also:

Attachments
Patch (14.75 KB, patch)
2014-02-02 16:12 PST, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2014-02-02 16:12:19 PST 
RenderSVGInlineText::computeNewScaledFontForStyle() should take references.
Comment 1 Andreas Kling 2014-02-02 16:12:46 PST 
Created attachment 222943 [details]
Patch
Comment 2 Darin Adler 2014-02-02 16:16:15 PST 
Comment on attachment 222943 [details]
Patch

Great changes. I made some of these same changes in my tree today.

Can we use a type more specific than RenderObject for any of this?
Comment 3 Andreas Kling 2014-02-02 16:23:13 PST 
(In reply to comment #2)
> Can we use a type more specific than RenderObject for any of this?

Alas, this codepath is used by both text and element renderers at the moment.
Comment 4 WebKit Commit Bot 2014-02-02 16:59:02 PST 
Comment on attachment 222943 [details]
Patch

Clearing flags on attachment: 222943

Committed r163276: <http://trac.webkit.org/changeset/163276>
Comment 5 WebKit Commit Bot 2014-02-02 16:59:05 PST 
All reviewed patches have been landed.  Closing bug.