Bug 12802 - WebKit.framework is built with SVG_SUPPORT for No-SVG build
Summary: WebKit.framework is built with SVG_SUPPORT for No-SVG build
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Minor
Assignee: Graham Dennis
Depends on:
Reported: 2007-02-18 02:56 PST by Graham Dennis
Modified: 2007-02-20 02:22 PST (History)
1 user (show)

See Also:

patch (1.98 KB, patch)
2007-02-18 03:05 PST, Graham Dennis
darin: review-
Details | Formatted Diff | Diff
patch 2 (2.00 KB, patch)
2007-02-19 14:34 PST, Graham Dennis
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Graham Dennis 2007-02-18 02:56:30 PST
The build-webkit script only causes WebCore to be built without the SVG_SUPPORT define for No-SVG builds, and doesn't do this for WebKit. This causes issues when WebKit tries to access virtual functions on Node as the SVG version of the Node class has an additional function (isSVGElement) that the No-SVG Node doesn't.

Patch forthcoming.
Comment 1 Graham Dennis 2007-02-18 03:05:33 PST
Created attachment 13221 [details]

Patch that modifies the build-webkit script.
Comment 2 Darin Adler 2007-02-19 08:30:19 PST
Comment on attachment 13221 [details]

This looks slightly sloppy to me. I'm not sure why JavaScriptCore should not have FEATURE_DEFINES, yet JavaScriptGlue should have it. And why have a separate elsif for WebCore if it's the same as the else case?

Would you be willing to try again? I think passing FEATURE_DEFINES to all the projects is fine, so the entire if/elsif/else can go.
Comment 3 Graham Dennis 2007-02-19 14:34:08 PST
Created attachment 13252 [details]
patch 2

New patch addressing Darin's comments
Comment 4 Darin Adler 2007-02-19 14:46:02 PST
Comment on attachment 13252 [details]
patch 2

Comment 5 Graham Dennis 2007-02-20 02:22:51 PST
Fixed in r19727.