Bug 127962 - Implement NavigationState::PolicyClient::decidePolicyForNewWindowAction
Summary: Implement NavigationState::PolicyClient::decidePolicyForNewWindowAction
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-30 15:14 PST by Anders Carlsson
Modified: 2014-01-30 15:19 PST (History)
1 user (show)

See Also:

Attachments
Patch (4.72 KB, patch)
2014-01-30 15:17 PST, Anders Carlsson 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2014-01-30 15:14:47 PST 
Implement NavigationState::PolicyClient::decidePolicyForNewWindowAction
Comment 1 Anders Carlsson 2014-01-30 15:17:14 PST 
Created attachment 222748 [details]
Patch
Comment 2 WebKit Commit Bot 2014-01-30 15:19:10 PST 
Attachment 222748 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/Cocoa/NavigationState.h:64:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebKit2/UIProcess/Cocoa/NavigationState.h:65:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2014-01-30 15:19:32 PST 
Committed r163129: <http://trac.webkit.org/changeset/163129>