WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
127962
Implement NavigationState::PolicyClient::decidePolicyForNewWindowAction
https://bugs.webkit.org/show_bug.cgi?id=127962
Summary
Implement NavigationState::PolicyClient::decidePolicyForNewWindowAction
Anders Carlsson
Reported
2014-01-30 15:14:47 PST
Implement NavigationState::PolicyClient::decidePolicyForNewWindowAction
Attachments
Patch
(4.72 KB, patch)
2014-01-30 15:17 PST
,
Anders Carlsson
kling
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2014-01-30 15:17:14 PST
Created
attachment 222748
[details]
Patch
WebKit Commit Bot
Comment 2
2014-01-30 15:19:10 PST
Attachment 222748
[details]
did not pass style-queue: ERROR: Source/WebKit2/UIProcess/Cocoa/NavigationState.h:64: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] ERROR: Source/WebKit2/UIProcess/Cocoa/NavigationState.h:65: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 3
2014-01-30 15:19:32 PST
Committed
r163129
: <
http://trac.webkit.org/changeset/163129
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug