Bug 127948 - Lots of API test assertion failures after r163093
Summary: Lots of API test assertion failures after r163093
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
Depends on:
Reported: 2014-01-30 14:07 PST by Tim Horton
Modified: 2014-01-30 14:45 PST (History)
6 users (show)

See Also:

patch (7.11 KB, patch)
2014-01-30 14:12 PST, Tim Horton
no flags Details | Formatted Diff | Diff
more ports (8.92 KB, patch)
2014-01-30 14:27 PST, Tim Horton
ap: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-01-30 14:07:17 PST
WKView should clean stuff up when the process terminates for any reason, not just a crash. Rename the function and make it clear the ViewGestureController. Also, don't make a ViewGestureController if we don't need one (if we don't have one, and the custom swipe view array is being cleared).
Comment 1 Tim Horton 2014-01-30 14:12:42 PST
Created attachment 222734 [details]
Comment 2 Tim Horton 2014-01-30 14:27:11 PST
Created attachment 222737 [details]
more ports
Comment 3 WebKit Commit Bot 2014-01-30 14:28:12 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 4 Alexey Proskuryakov 2014-01-30 14:41:57 PST
Comment on attachment 222737 [details]
more ports

Sadly, having a red tree means that EWS is slow, and doesn't tell us about this patch (or other new patches) quickly enough.
Comment 5 Tim Horton 2014-01-30 14:45:10 PST