Bug 127935 - DumpRenderTree fails to build with ASAN: -fsanitize=address passed to static DRT target
Summary: DumpRenderTree fails to build with ASAN: -fsanitize=address passed to static ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: David Farler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-30 12:51 PST by David Farler
Modified: 2014-01-30 13:31 PST (History)
2 users (show)

See Also:

Attachments
Patch (1.84 KB, patch)
2014-01-30 12:57 PST, David Farler 		aestes: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Farler 2014-01-30 12:51:51 PST 
Libtool /Volumes/Data/BuildSlave/build-asan-webkit/OpenSource/WebKitBuild/Release/libDumpRenderTree.a normal x86_64
    cd /Volumes/Data/BuildSlave/build-asan-webkit/OpenSource/Tools/DumpRenderTree
    /Applications/Xcode.app/Contents/Developer/Toolchains/ASAN.xctoolchain/usr/bin/libtool -static -arch_only x86_64 -syslibroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.9.Internal.sdk -L/Volumes/Data/BuildSlave/build-asan-webkit/OpenSource/WebKitBuild/Release -filelist /Volumes/Data/BuildSlave/build-asan-webkit/OpenSource/WebKitBuild/DumpRenderTree.build/Release/DumpRenderTree\ (Library).build/Objects-normal/x86_64/DumpRenderTree.LinkFileList -fsanitize=address -lclang_rt.asan_osx_dynamic -o /Volumes/Data/BuildSlave/build-asan-webkit/OpenSource/WebKitBuild/Release/libDumpRenderTree.a
/Applications/Xcode.app/Contents/Developer/Toolchains/ASAN.xctoolchain/usr/bin/libtool: unknown option character `f' in: -fsanitize=address
Comment 1 David Farler 2014-01-30 12:57:30 PST 
Created attachment 222716 [details]
Patch
Comment 2 Andy Estes 2014-01-30 13:18:05 PST 
Comment on attachment 222716 [details]
Patch

r=me, but I'd rather this be done in DumpRenderTreeLibrary.xcconfig.
Comment 3 David Farler 2014-01-30 13:21:39 PST 
Committed r163107: <http://trac.webkit.org/changeset/163107>
Comment 4 David Farler 2014-01-30 13:31:52 PST 
Committed r163110: http://trac.webkit.org/changeset/163110
(Moved to xcconfig)