Bug 127912 – IDB: Add no-op plumbing for deleteDatabase and deleteRange

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Brady Eidson]

IDB: Add no-op plumbing for deleteDatabase and deleteRange

To get rid of future busywork...

[Brady Eidson]

Created attachment 222676 [details]
Patch v1

[WebKit Commit Bot]

Attachment 222676 [details] did not pass style-queue:


ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.h:91:  The parameter name "keyRange" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:650:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 2 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alexey Proskuryakov]

Comment on attachment 222676 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=222676&action=review

> Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:639
> +void UniqueIDBDatabase::deleteRange(const IDBIdentifier& transactionIdentifier, int64_t objectStoreID, const WebCore::IDBKeyRangeData& keyRangeData, std::function<void(uint32_t, const String&)> callback)

Please check all cpp files for WebCore namespace prefixes, and remove them.

[Brady Eidson]

(In reply to comment #3)
> (From update of attachment 222676 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=222676&action=review
> 
> > Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:639
> > +void UniqueIDBDatabase::deleteRange(const IDBIdentifier& transactionIdentifier, int64_t objectStoreID, const WebCore::IDBKeyRangeData& keyRangeData, std::function<void(uint32_t, const String&)> callback)
> 
> Please check all cpp files for WebCore namespace prefixes, and remove them.

Whoops, thanks!

[Brady Eidson]

http://trac.webkit.org/changeset/163087