Bug 127666 - CaptionUserPreferences should not be on the PageGroup if they are not really per-PageGroup
Summary: CaptionUserPreferences should not be on the PageGroup if they are not really ...
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on: 127890
Blocks:
  Show dependency tree / graph
 
Reported: 2014-01-26 18:36 PST by Sam Weinig
Modified: 2014-01-30 00:30 PST (History)
13 users (show)

See Also:

Attachments
Part 1 (88.24 KB, patch)
2014-01-26 18:57 PST, Sam Weinig 		no flags Details | Formatted Diff | Diff
Part 1 (88.26 KB, patch)
2014-01-26 19:12 PST, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (87.96 KB, patch)
2014-01-26 20:47 PST, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (88.39 KB, patch)
2014-01-26 21:10 PST, Sam Weinig 		eric.carlson: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 (495.58 KB, application/zip)
2014-01-29 13:57 PST, Build Bot 		no flags Details
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2014-01-26 18:36:27 PST 
CaptionUserPreferences should not be on the PageGroup if they are not really per-PageGroup
Comment 1 Sam Weinig 2014-01-26 18:57:38 PST 
Created attachment 222295 [details]
Part 1
Comment 2 Sam Weinig 2014-01-26 19:01:16 PST 
Comment on attachment 222295 [details]
Part 1

Not ready for prime time yet.
Comment 3 Sam Weinig 2014-01-26 19:12:54 PST 
Created attachment 222296 [details]
Part 1
Comment 4 Sam Weinig 2014-01-26 20:47:46 PST 
Created attachment 222300 [details]
Patch
Comment 5 Sam Weinig 2014-01-26 21:10:04 PST 
Created attachment 222301 [details]
Patch
Comment 6 Build Bot 2014-01-29 13:57:06 PST 
Comment on attachment 222301 [details]
Patch

Attachment 222301 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6466608323100672

New failing tests:
platform/mac/accessibility/aria-setsize-posinset.html
accessibility/canvas-fallback-content-2.html
accessibility/div-within-anchors-causes-crash.html
accessibility/canvas-description-and-role.html
platform/mac/accessibility/option-with-lang.html
Comment 7 Build Bot 2014-01-29 13:57:09 PST 
Created attachment 222593 [details]
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-13  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 8 Sam Weinig 2014-01-29 16:30:50 PST 
Committed r163048: <http://trac.webkit.org/changeset/163048>
Comment 9 Alexey Proskuryakov 2014-01-29 23:31:09 PST 
(In reply to comment #6)
> New failing tests:
> platform/mac/accessibility/aria-setsize-posinset.html
> accessibility/canvas-fallback-content-2.html
> accessibility/div-within-anchors-causes-crash.html
> accessibility/canvas-description-and-role.html
> platform/mac/accessibility/option-with-lang.html

How could this be landed over all these errors detected by EWS? There are even more on mac-wk1.
Comment 10 WebKit Commit Bot 2014-01-29 23:33:20 PST 
Re-opened since this is blocked by bug 127890
Comment 12 Csaba Osztrogonác 2014-01-30 00:30:02 PST 
The Windows buildfix http://trac.webkit.org/changeset/163052 rolled out 
by http://trac.webkit.org/changeset/163077 to fix the Windows build.