Bug 127655 - Web Inspector: Prefix existing Profiler UI classes with "Legacy"
Summary: Web Inspector: Prefix existing Profiler UI classes with "Legacy"
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
Keywords: InRadar
Depends on:
Reported: 2014-01-26 12:08 PST by Timothy Hatcher
Modified: 2014-01-30 17:30 PST (History)
4 users (show)

See Also:

Patch (185.26 KB, patch)
2014-01-26 12:16 PST, Timothy Hatcher
no flags Details | Formatted Diff | Diff
Better Patch (67.08 KB, patch)
2014-01-26 12:17 PST, Timothy Hatcher
joepeck: review+
timothy: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2014-01-26 12:08:25 PST
We need to keep the old profiler classes around to support iOS 6 & 7.

Also remove the unfinished Canvas profiler classes, they will need redone for the Timeline view. These didn't exist on iOS 6 & 7.
Comment 1 Radar WebKit Bug Importer 2014-01-26 12:08:39 PST
Comment 2 Timothy Hatcher 2014-01-26 12:16:48 PST
Created attachment 222280 [details]
Comment 3 Timothy Hatcher 2014-01-26 12:17:53 PST
Created attachment 222281 [details]
Better Patch
Comment 4 Joseph Pecoraro 2014-01-28 16:06:38 PST
Comment on attachment 222281 [details]
Better Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=222281&action=review


> Source/WebInspectorUI/UserInterface/Main.js:-58
> -    if (InspectorBackend.registerCanvasDispatcher)
> -        InspectorBackend.registerCanvasDispatcher(new WebInspector.CanvasObserver);

Do you want to also delete the Canvas protocol/agent at this time?
Comment 5 Timothy Hatcher 2014-01-30 17:30:58 PST