RESOLVED FIXED 127638
Remove FIXME in CSSKeywordCompletions.js about "inherit" keyword 
https://bugs.webkit.org/show_bug.cgi?id=127638
Summary Remove FIXME in CSSKeywordCompletions.js about "inherit" keyword
Joseph Pecoraro
Reported 2014-01-25 19:22:35 PST
Replace the confused FIXME comment with an answer about why "inherit" is only added some of the time despite it always being valid.
Attachments
[PATCH] Proposed Fix (1.76 KB, patch)
2014-01-25 19:24 PST, Joseph Pecoraro 		timothy: review+
DetailsFormatted DiffDiff
[PATCH] For Landing (1.94 KB, patch)
2014-01-25 19:35 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2014-01-25 19:24:13 PST
Created attachment 222246 [details] [PATCH] Proposed Fix
Timothy Hatcher
Comment 2 2014-01-25 19:25:13 PST
Comment on attachment 222246 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=222246&action=review > Source/WebInspectorUI/ChangeLog:1 > +2014-01-25 Joseph Pecoraro <joepeck02@gmail.com> Right email address?
Joseph Pecoraro
Comment 3 2014-01-25 19:33:33 PST
Bah good catch. The whole reason I put this up on a bug was cause I'm writing on a machine without a checkout that can commit. I'll update that! Thanks
Joseph Pecoraro
Comment 4 2014-01-25 19:35:05 PST
Created attachment 222247 [details] [PATCH] For Landing
WebKit Commit Bot
Comment 5 2014-01-25 20:10:50 PST
Comment on attachment 222247 [details] [PATCH] For Landing Clearing flags on attachment: 222247 Committed r162794: <http://trac.webkit.org/changeset/162794>
WebKit Commit Bot
Comment 6 2014-01-25 20:10:57 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.