Bug 127638 - Remove FIXME in CSSKeywordCompletions.js about "inherit" keyword
Summary: Remove FIXME in CSSKeywordCompletions.js about "inherit" keyword
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2014-01-25 19:22 PST by Joseph Pecoraro
Modified: 2014-01-25 20:10 PST (History)
4 users (show)

See Also:

[PATCH] Proposed Fix (1.76 KB, patch)
2014-01-25 19:24 PST, Joseph Pecoraro
timothy: review+
Details | Formatted Diff | Diff
[PATCH] For Landing (1.94 KB, patch)
2014-01-25 19:35 PST, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-01-25 19:22:35 PST
Replace the confused FIXME comment with an answer about why "inherit" is only added some of the time despite it always being valid.
Comment 1 Joseph Pecoraro 2014-01-25 19:24:13 PST
Created attachment 222246 [details]
[PATCH] Proposed Fix
Comment 2 Timothy Hatcher 2014-01-25 19:25:13 PST
Comment on attachment 222246 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=222246&action=review

> Source/WebInspectorUI/ChangeLog:1
> +2014-01-25  Joseph Pecoraro  <joepeck02@gmail.com>

Right email address?
Comment 3 Joseph Pecoraro 2014-01-25 19:33:33 PST
Bah good catch. The whole reason I put this up on a bug was cause I'm writing on a machine without a checkout that can commit. I'll update that! Thanks
Comment 4 Joseph Pecoraro 2014-01-25 19:35:05 PST
Created attachment 222247 [details]
[PATCH] For Landing
Comment 5 WebKit Commit Bot 2014-01-25 20:10:50 PST
Comment on attachment 222247 [details]
[PATCH] For Landing

Clearing flags on attachment: 222247

Committed r162794: <http://trac.webkit.org/changeset/162794>
Comment 6 WebKit Commit Bot 2014-01-25 20:10:57 PST
All reviewed patches have been landed.  Closing bug.