Bug 127454 - WKBrowsingContextController should not be an API wrapper around WebPageProxy
Summary: WKBrowsingContextController should not be an API wrapper around WebPageProxy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-22 16:36 PST by Anders Carlsson
Modified: 2014-01-22 18:19 PST (History)
0 users

See Also:

Attachments
Patch (11.56 KB, patch)
2014-01-22 16:36 PST, Anders Carlsson 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2014-01-22 16:36:04 PST 
WKBrowsingContextController should not be an API wrapper around WebPageProxy
Comment 1 Anders Carlsson 2014-01-22 16:36:24 PST 
Created attachment 221923 [details]
Patch
Comment 2 mitz 2014-01-22 18:18:39 PST 
Comment on attachment 221923 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221923&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextControllerInternal.h:42
> -- (void)_finishInitialization;
>  + (NSMutableSet *)customSchemes;
>  
> +- (instancetype)_initWithPageRef:(WKPageRef)pageRef;
> ++ (WKBrowsingContextController *)_browsingContextControllerForPageRef:(WKPageRef)pageRef;

Class methods before instance methods, please.
Comment 3 Anders Carlsson 2014-01-22 18:19:39 PST 
Committed r162580: <http://trac.webkit.org/changeset/162580>