Bug 127453 - The IDB backing store get() method shouldn't call IDB callbacks directly
Summary: The IDB backing store get() method shouldn't call IDB callbacks directly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-22 16:14 PST by Brady Eidson
Modified: 2014-01-22 16:26 PST (History)
4 users (show)

See Also:

Attachments
Patch v1 (17.27 KB, patch)
2014-01-22 16:18 PST, Brady Eidson 		bdakin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2014-01-22 16:14:05 PST 
The IDB backing store get() method shouldn't call IDB callbacks directly

This is similar to https://bugs.webkit.org/show_bug.cgi?id=127399 but for get() instead of put()
Comment 1 Brady Eidson 2014-01-22 16:18:35 PST 
Created attachment 221919 [details]
Patch v1
Comment 2 Beth Dakin 2014-01-22 16:20:59 PST 
Comment on attachment 221919 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=221919&action=review

> Source/WebCore/ChangeLog:15
> +        (WebCore::IDBServerConnectionLevelDB::get): Donât call IDBCallbacks directly.

Funny character.
Comment 3 WebKit Commit Bot 2014-01-22 16:21:02 PST 
Attachment 221919 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Brady Eidson 2014-01-22 16:26:21 PST 
http://trac.webkit.org/changeset/162569