Bug 127393 – WebKit2 View Gestures (Swipe): Swipe-start hysteresis

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Tim Horton]

We shouldn't start a swipe immediately upon very small scrolls in the correct direction, because we don't want to get the user trapped in a swipe. Instead, we should have some hysteresis mechanism to make sure the user really wants to swipe.

[Radar WebKit Bug Importer]

<rdar://problem/15876822>

[Tim Horton]

Created attachment 228422 [details]
patch

[Build Bot]

Comment on attachment 228422 [details]
patch

Attachment 228422 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5221395600506880

New failing tests:
media/W3C/audio/canPlayType/canPlayType_application_octet_stream_with_codecs_1.html

[Build Bot]

Created attachment 228452 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Tim Horton]

Comment on attachment 228422 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228422&action=review

> Source/WebKit2/UIProcess/mac/ViewGestureControllerMac.mm:271
> +    // If a single scroll event in the sequence is "too vertical", we will stop tracking this
> +    // as a potential swipe until we get another "begin" event.

This comment isn't quite right.

[Tim Horton]

http://trac.webkit.org/changeset/166941