Bug 127393 - WebKit2 View Gestures (Swipe): Swipe-start hysteresis
Summary: WebKit2 View Gestures (Swipe): Swipe-start hysteresis
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
Keywords: InRadar
Depends on:
Reported: 2014-01-21 18:14 PST by Tim Horton
Modified: 2014-04-08 12:01 PDT (History)
7 users (show)

See Also:

patch (7.92 KB, patch)
2014-04-02 13:30 PDT, Tim Horton
andersca: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 (561.61 KB, application/zip)
2014-04-02 18:31 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-01-21 18:14:50 PST
We shouldn't start a swipe immediately upon very small scrolls in the correct direction, because we don't want to get the user trapped in a swipe. Instead, we should have some hysteresis mechanism to make sure the user really wants to swipe.
Comment 1 Radar WebKit Bug Importer 2014-01-21 18:15:30 PST
Comment 2 Tim Horton 2014-04-02 13:30:33 PDT
Created attachment 228422 [details]
Comment 3 Build Bot 2014-04-02 18:31:15 PDT
Comment on attachment 228422 [details]

Attachment 228422 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5221395600506880

New failing tests:
Comment 4 Build Bot 2014-04-02 18:31:17 PDT
Created attachment 228452 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 5 Tim Horton 2014-04-03 13:23:31 PDT
Comment on attachment 228422 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=228422&action=review

> Source/WebKit2/UIProcess/mac/ViewGestureControllerMac.mm:271
> +    // If a single scroll event in the sequence is "too vertical", we will stop tracking this
> +    // as a potential swipe until we get another "begin" event.

This comment isn't quite right.
Comment 6 Tim Horton 2014-04-08 12:01:13 PDT